Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[storage] log_manager::remove_orphan_files: error -> trace for ENOENT #11441

Merged

Conversation

andijcr
Copy link
Contributor

@andijcr andijcr commented Jun 14, 2023

This function can race with segment::close before being able to call orphan_filter. This commit lowers the log level similar to how it is done in segment::close

Fixes #10366

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.1.x
  • v22.3.x
  • v22.2.x

Release Notes

  • none

this function can race with segment::close before being able to call
orphan_filter. this commit lowers the log level similarly to how is done
in segment::close
@piyushredpanda
Copy link
Contributor

@andijcr is this ready for review?

@andijcr andijcr marked this pull request as ready for review June 15, 2023 09:50
@andijcr
Copy link
Contributor Author

andijcr commented Jun 15, 2023

/ci-repeat 3 skip-units dt-repeat=10 tests/rptest/tests/cloud_storage_chunk_read_path_test.py::CloudStorageChunkReadTest.test_read_when_cache_smaller_than_segment_size

@andijcr andijcr merged commit f92380f into redpanda-data:dev Jun 15, 2023
@andijcr andijcr deleted the issue/10366/bad_log_line_missing_file branch June 15, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants