Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ducktape/test_simple_live_change: wait for all nodes #11156

Merged

Conversation

BenPope
Copy link
Member

@BenPope BenPope commented Jun 1, 2023

The test is checking config status, but it is not waiting for the status object to have content for all the expected nodes.

Fixes #10977

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.1.x
  • v22.3.x
  • v22.2.x

Not seen on v23.1.x in the last 14d / 55 runs.

Release Notes

  • none

The test is checking config status, but it is not waiting for
the status object to have content for all the expected nodes.

Fixes redpanda-data#10977

Signed-off-by: Ben Pope <[email protected]>
@BenPope BenPope requested review from dlex and jcsp June 1, 2023 22:37
@BenPope
Copy link
Member Author

BenPope commented Jun 1, 2023

Tested locally.

Without:

SESSION REPORT (ALL TESTS)
ducktape version: 0.8.8
session_id:       2023-06-01--046
run time:         2 minutes 59.723 seconds
tests run:        100
passed:           87
failed:           13
ignored:          0
opassed:          0
ofailed:          0

With this fix:

ducktape version: 0.8.8
session_id:       2023-06-01--047
run time:         30 minutes 27.879 seconds
tests run:        1000
passed:           1000
failed:           0
ignored:          0
opassed:          0
ofailed:          0

Copy link
Member

@dotnwat dotnwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@piyushredpanda piyushredpanda merged commit c0f3996 into redpanda-data:dev Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI Failure (assert self.admin.get_cluster_config) in ClusterConfigTest.test_simple_live_change
3 participants