Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

partition_allocator: preserve shards for replicas on original nodes #11077

Merged
merged 4 commits into from
May 30, 2023
Merged

partition_allocator: preserve shards for replicas on original nodes #11077

merged 4 commits into from
May 30, 2023

Commits on May 26, 2023

  1. cluster: reduce transitive inclusion of partition_allocator.h

    @ztlpn
    ztlpn committed May 26, 2023
    Configuration menu
    Copy the full SHA
    0b0c782 View commit details
    Browse the repository at this point in the history

  2. c/partition_allocator: move choosing shard out of allocation_strategy 

    This is in preparation for preserving the shard when moving replicas to
original nodes - we want to choose the shard in partition_allocator
itself, not in allocation_strategy.
    @ztlpn
    ztlpn committed May 26, 2023
    Configuration menu
    Copy the full SHA
    36bb5ab View commit details
    Browse the repository at this point in the history

  3. c/partition_allocator: preserve shards for replicas on original nodes 

    After one or several reallocations a replica may end up on one of the
original nodes. Previously, we chose the shard for this replica anew in
this case. This is awkward because the shard could change so the full
replica id (i.e. broker_shard) changed even if the reallocation didn't
change anything in the grand scheme of things. So this commit makes
reallocations preserve the shard of replicas that end up on original
nodes.

And of course this change makes it easier in the future to let nodes
choose shards for the replicas they host themselves.
    @ztlpn
    ztlpn committed May 26, 2023
    Configuration menu
    Copy the full SHA
    42ade6f View commit details
    Browse the repository at this point in the history

  4. c/partition_allocator: add test for preserving original replica shards

    @ztlpn
    ztlpn committed May 26, 2023
    Configuration menu
    Copy the full SHA
    f505447 View commit details
    Browse the repository at this point in the history