Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require conn_quota::units stay on a single shard #10681

Merged
merged 3 commits into from
Jun 2, 2023
Merged

Require conn_quota::units stay on a single shard #10681

merged 3 commits into from
Jun 2, 2023

Commits on Jun 1, 2023

  1. Upgrade to std::source_location 

    Upgrades oncore and vlog to use std::source_location, removing
__FILE__ and __LINE__ macro usage. This means it's easier to use oncore
without a macro.

Signed-off-by: Tyler Rockwood <[email protected]>
    @rockwotj
    rockwotj committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    dc62129 View commit details
    Browse the repository at this point in the history

  2. Require conn_quota::units stay on a single shard 

    This makes the API contract more explicit since we now require the
connection quota doesn't change shards.

Related: redpanda-data#10544

Signed-off-by: Tyler Rockwood <[email protected]>
    @rockwotj
    rockwotj committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    f5d2b66 View commit details
    Browse the repository at this point in the history

  3. Log total_home when used 

    I have a theory total_home (only set on shard0's service) could be ran
using a service from another shard, but on shard0. We should add logs
for what total_allowance is because that's what the stacktrace reported
as crashing.

Signed-off-by: Tyler Rockwood <[email protected]>
    @rockwotj
    rockwotj committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    98e5386 View commit details
    Browse the repository at this point in the history