Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ps filtering in ducktape #10294

Merged
merged 1 commit into from
May 2, 2023
Merged

Fix ps filtering in ducktape #10294

merged 1 commit into from
May 2, 2023

Conversation

michael-redpanda
Copy link
Contributor

@michael-redpanda michael-redpanda commented Apr 24, 2023 •
edited by vshtokman
Loading

Fixes #10277

Force push e83147c:

  • Replaced ps ax with pidof

Force push 459db6a:

  • Reverted back to ps ax | grep

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.1.x
  • v22.3.x
  • v22.2.x

Release Notes

  • none

@michael-redpanda
Copy link
Contributor Author

/cdt
dt-repeat=10
tests/rptest/tests/rpk_start_test.py::RpkRedpandaStartTest

@michael-redpanda
Copy link
Contributor Author

/cdt
dt-repeat=10
rp_version=build
dt-log-level=debug
tests/rptest/tests/rpk_start_test.py::RpkRedpandaStartTest

@michael-redpanda
Copy link
Contributor Author

/cdt
dt-repeat=5
rp_version=build
dt-log-level=debug
tests/rptest/tests/rpk_start_test.py::RpkRedpandaStartTest

2 similar comments
@michael-redpanda
Copy link
Contributor Author

/cdt
dt-repeat=5
rp_version=build
dt-log-level=debug
tests/rptest/tests/rpk_start_test.py::RpkRedpandaStartTest

@michael-redpanda
Copy link
Contributor Author

/cdt
dt-repeat=5
rp_version=build
dt-log-level=debug
tests/rptest/tests/rpk_start_test.py::RpkRedpandaStartTest

@michael-redpanda michael-redpanda mentioned this pull request Apr 26, 2023
Closed
@michael-redpanda
tests/redpanda: Don't exclude redpanda with ']' in args
459db6a 
A change was introduced in 81c37c5 that attempted to fix an issue where
an incorrect process was selected as the redpanda process.  The
unintended side-effect was that any actual Redpanda process that
contained a ']' was excluded so methods like `self.redpanda.stop()`
wouldn't actually stop Redpanda as it was unable to find the appropriate
PID.

Fixed `ps` line to exclude "[redpanda]" rather than just "]".

Signed-off-by: Michael Boquard <[email protected]>
@michael-redpanda michael-redpanda changed the title application: Check return code of atexit(3) Fix ps filtering in ducktape Apr 26, 2023
@michael-redpanda michael-redpanda marked this pull request as ready for review April 26, 2023 21:12
@michael-redpanda michael-redpanda self-assigned this Apr 26, 2023
@michael-redpanda
Copy link
Contributor Author

/cdt
rp_version=build

@michael-redpanda
Copy link
Contributor Author

CI failure:

@NyaliaLui
Copy link
Contributor

/ci-repeat 5
dt-repeat=100
tests/rptest/tests/rpk_start_test.py::RpkRedpandaStartTest.test_rpc_tls_enable tests/rptest/tests/rpk_start_test.py::RpkRedpandaStartTest.test_rpc_tls_start

NyaliaLui
NyaliaLui previously approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@NyaliaLui NyaliaLui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but let's run CI a few more times on the failed tests to be sure.

@BenPope BenPope mentioned this pull request Apr 28, 2023
Merged
7 tasks
@michael-redpanda
Copy link
Contributor Author

Linter error fixed in #10439

@michael-redpanda
Copy link
Contributor Author

/ci-repeat 5

@michael-redpanda
Copy link
Contributor Author

CI Failures:

@piyushredpanda piyushredpanda merged commit 70afa3c into redpanda-data:dev May 2, 2023
@michael-redpanda
Copy link
Contributor Author

/backport v23.1.x

@michael-redpanda
Copy link
Contributor Author

/backport v22.3.x

@michael-redpanda
Copy link
Contributor Author

/backport v22.2.x

@vbotbuildovich
Copy link
Collaborator

Failed to run cherry-pick command. I executed the below command:

git cherry-pick -x 459db6aaebcc984f13ce1e36819da6f10f12e18c

Workflow run logs.

@vbotbuildovich vbotbuildovich mentioned this pull request May 2, 2023
Closed
@vbotbuildovich
Copy link
Collaborator

Failed to run cherry-pick command. I executed the below command:

git cherry-pick -x 459db6aaebcc984f13ce1e36819da6f10f12e18c

Workflow run logs.

This was referenced May 2, 2023
Closed
Closed
Merged
This was referenced May 2, 2023
Closed
Merged
Closed
Merged
@ztlpn ztlpn mentioned this pull request May 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NyaliaLui NyaliaLui NyaliaLui approved these changes

@dotnwat dotnwat Awaiting requested review from dotnwat

@mmaslankaprv mmaslankaprv Awaiting requested review from mmaslankaprv

@BenPope BenPope Awaiting requested review from BenPope

@ztlpn ztlpn Awaiting requested review from ztlpn

Assignees

@michael-redpanda michael-redpanda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI Failure (pidfile locked) in rpk_start_test.RpkRedpandaStartTest.test_rpc_tls_enable
6 participants
@michael-redpanda @NyaliaLui @vbotbuildovich @BenPope @mmaslankaprv @piyushredpanda