rptest: fix cloud start kafka offset computation #10262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VladLazar
added
area/redpanda
area/tests
area/cloud-storage
|
/ci-repeat 5 |
jcsp
previously approved these changes
Apr 21, 2023
|
Let's wait for the |
7 tasks
Lazin
previously approved these changes
Apr 21, 2023
|
A lot of runs failed due to disk space. Triggering another ci-repeat... |
|
/ci-repeat 5 |
VladLazar
force-pushed
the
fix-cloud-start-kafka-offset-computation
branch
from
770cf10
to
b3a99d5
Compare
|
/ci-repeat 5 |
VladLazar
force-pushed
the
fix-cloud-start-kafka-offset-computation
branch
from
b3a99d5
to
991e4d5
Compare
|
/ci-repeat 5 |
added 2 commits
April 21, 2023 15:09
Previously, `BucketView.kafka_start_offset` computed the start Kafka offset from the manifest from the segment with the min `base_offset`. Since the manifest is allowed to have entries in 'segments' that are below 'start_offset', it broke when, in a recent change, we stopped uploading after the housekeeping. This commit fixes the failures in `CloudStorageTimingStressTest` by correcting the util function mentioned above. Cloud retention always operats on segment boundaries. There are two cases: 1. Start offset is advanced to the `base_offset` of another segment 2. Start offset is advanced to the `committed_offset + 1` of the latest segment at the time. This happens when retention decides to remove all segments from the cloud to satisfy the retention policy. Both cases are now handled correctly.
VladLazar
force-pushed
the
fix-cloud-start-kafka-offset-computation
branch
from
991e4d5
to
ed5ac40
Compare
|
/ci-repeat 5 |
|
The latest CI repeat was green. This is good to merge IMO. |
andrwng
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
BucketView.kafka_start_offsetcomputed the start Kafka offset from the manifest from the segment with the minbase_offset. Since the manifest is allowed to have entries in 'segments' that are below 'start_offset', it broke when, in a recent change, we stopped uploading after the housekeeping.This commit fixes the failures in
CloudStorageTimingStressTestby correcting the util function mentioned above. Cloud retention always operats on segment boundaries. There are two cases:base_offsetof another segmentcommited_offset + 1of the latest segment at the time. This happens when retention decides to remove all segments from the cloud to satisfy the retention policy.Both cases are now handled correctly.
Related #10130
Fixes #10241
Backports Required
Release Notes