Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support shared library build of Redpanda #10220

Merged
merged 3 commits into from
Apr 20, 2023
Merged

Support shared library build of Redpanda #10220

merged 3 commits into from
Apr 20, 2023

Commits on Apr 20, 2023

  1. cloud_storage: move services into libcluster 

    The partition recovery manager and topic recovery service are moved from
cloud storage into the cluster library. The recovery services make sense
to be outside the leaner cloud storage library, and importantly, it
breaks a circular dependency between the two subsystems.

Signed-off-by: Noah Watkins <[email protected]>
    @dotnwat
    dotnwat committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    dec1370 View commit details
    Browse the repository at this point in the history

  2. archival: compile archival into cluster library 

    The archival and cluster libraries are intertwined to the point that
separating them to resolve a circular dependency has proved quite
difficult. On the other hand, compiling archival into the cluster
library itself fully resolves the issue.

This commit does not move any files, but merely changes the build system
to reflect the new compilation strategy. This is useful because there
are many inflight changes that would incur a large cost due to a file
move and namespace changes. Future clean up should address this
temporary layout.

Signed-off-by: Noah Watkins <[email protected]>
    @dotnwat
    dotnwat committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    6aa17c8 View commit details
    Browse the repository at this point in the history

  3. build: adjust cmake deps to support shared library 

    Primarily this addresses missing dependencies that are required in a
shared library build.

Signed-off-by: Noah Watkins <[email protected]>
    @dotnwat
    dotnwat committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    a18c1fb View commit details
    Browse the repository at this point in the history