Support compressed batches in kafka client #10117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-redpanda
requested review from
BenPope,
NyaliaLui,
dlex and
graphcareful
michael-redpanda
force-pushed
the
support-compressed-batches-in-kafka-client
branch
from
57c3ca9
to
a0b36eb
Compare
BenPope
reviewed
Apr 17, 2023
michael-redpanda
force-pushed
the
support-compressed-batches-in-kafka-client
branch
from
a0b36eb
to
03e3616
Compare
Added calls that will decompress record_batch's synchronously
Added calls that will decompress record_batch's synchronously when fetched via kafka client.
michael-redpanda
force-pushed
the
support-compressed-batches-in-kafka-client
branch
from
03e3616
to
8bc0c58
Compare
BenPope
previously approved these changes
Apr 18, 2023
Added two tests, one for direct partition fetch and an additional one that will use consumer groups. Signed-off-by: Michael Boquard <[email protected]>
Fixes: redpanda-data#8546 Signed-off-by: Michael Boquard <[email protected]>
michael-redpanda
force-pushed
the
support-compressed-batches-in-kafka-client
branch
from
8bc0c58
to
c1dc4c7
Compare
BenPope
approved these changes
Apr 18, 2023
michael-redpanda
added
area/pandaproxy
michael-redpanda
force-pushed
the
support-compressed-batches-in-kafka-client
branch
from
c1dc4c7
to
641c437
Compare
dotnwat
approved these changes
Apr 18, 2023
|
/backport v23.1.x |
|
/backport v22.3.x |
|
/backport v22.2.x |
This was referenced Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3062
Fixes #8546
Pandaproxy can how handle compressed batches and return them upon consumption. Schema registry also can now
consume compressed batches saved to the
_schemastopic.Backports Required
Release Notes
Bug Fixes
_schemastopic contains compressed batches