kgo-verifier: close client in produceInner #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On "unexpected offsets" conditions, the producer will drop out of produceInner and re-enter, to destroy and create a client. However, dropping the reference to the client doesn't synchronously close it, so it's possible for the client to remain alive too long, and perhaps continue to drain its produce channel, disrupting the offset checks in the subsequent call to produceInner. It's not certain that we've seen this happen, but it is one possibility discussed in redpanda-data/redpanda#8289 that is straightforward to eliminate. Related: redpanda-data/redpanda#8289
andrwng
approved these changes
Feb 7, 2023
jcsp
added a commit
to jcsp/redpanda
that referenced
this pull request
Feb 8, 2023
To pull in - redpanda-data/kgo-verifier#20 - redpanda-data/kgo-verifier#21 (producer rate limit)
jcsp
added a commit
to jcsp/redpanda
that referenced
this pull request
Feb 13, 2023
To pull in - redpanda-data/kgo-verifier#20 - redpanda-data/kgo-verifier#21 (producer rate limit)
jcsp
added a commit
to jcsp/redpanda
that referenced
this pull request
Mar 1, 2023
To pull in - redpanda-data/kgo-verifier#20 - redpanda-data/kgo-verifier#21 (producer rate limit) (cherry picked from commit 65e001f)
jcsp
added a commit
to jcsp/redpanda
that referenced
this pull request
Mar 1, 2023
To pull in - redpanda-data/kgo-verifier#20 - redpanda-data/kgo-verifier#21 (producer rate limit) (cherry picked from commit 65e001f)
jcsp
added a commit
to jcsp/redpanda
that referenced
this pull request
Mar 1, 2023
To pull in - redpanda-data/kgo-verifier#20 - redpanda-data/kgo-verifier#21 (producer rate limit) (cherry picked from commit 65e001f)
jcsp
added a commit
to jcsp/redpanda
that referenced
this pull request
Mar 1, 2023
To pull in - redpanda-data/kgo-verifier#20 - redpanda-data/kgo-verifier#21 (producer rate limit) (cherry picked from commit 65e001f)
jcsp
added a commit
to jcsp/redpanda
that referenced
this pull request
Mar 8, 2023
To pull in - redpanda-data/kgo-verifier#20 - redpanda-data/kgo-verifier#21 (producer rate limit) (cherry picked from commit 65e001f)
jcsp
added a commit
to jcsp/redpanda
that referenced
this pull request
Mar 8, 2023
To pull in - redpanda-data/kgo-verifier#20 - redpanda-data/kgo-verifier#21 (producer rate limit) (cherry picked from commit 65e001f)
jcsp
added a commit
to jcsp/redpanda
that referenced
this pull request
Mar 13, 2023
To pull in - redpanda-data/kgo-verifier#20 - redpanda-data/kgo-verifier#21 (producer rate limit) (cherry picked from commit 65e001f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On "unexpected offsets" conditions, the producer
will drop out of produceInner and re-enter, to
destroy and create a client.
However, dropping the reference to the client doesn't synchronously close it, so it's possible for the
client to remain alive too long, and perhaps continue to drain its produce channel, disrupting the offset checks in the subsequent call to produceInner.
It's not certain that we've seen this happen, but it is one possibility discussed in redpanda-data/redpanda#8289 that is straightforward to eliminate.
Related: redpanda-data/redpanda#8289