-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comply with Django async syntax #22
Conversation
Tests seem to be broken on Windows
So I'll rely on the GitHub workflow to test this PR. |
Thank you @Archmonger , the idea was to keep both the new django syntax and keep the old one, just to avoid breaking things for those who still use the current syntax. But perhaps we can add a Deprecation warning for the old one. |
Sure will do |
Btw do you want to avoid replacing existing Django methods? For example, if the user's Django version already has |
I highly recommend doing a squash merge on this one, since the commit log is quite messy. |
Thank you @Archmonger for this amazing work, I will look at it and squash-merge if everything is good ! |
Let me know when you can review this PR. After this gets merged, I'll PR the following |
@rednaks Can you either merge this PR or add me as a maintainer? I'd like to get his repo into a production-ready state. |
Changelog
a*
functions (if they exist)a*
query functionsasync_*
query functions