Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psych 4: Psych::BadAlias exception when unserializing a config/s3.yml #32

Merged
merged 2 commits into from
Mar 7, 2022

Conversation

yui-har
Copy link
Collaborator

@yui-har yui-har commented Mar 4, 2022

When the plugin tries to read a YAML file like the one below, the exception Psych::BadAlias is raised.

s3_default: &default
  bucket: bucket-name
  folder: folder/files
  thumb_folder: folder/thumb

development:
  <<: *default

Psych 4.0 uses safe_load by default (see ruby/psych#487). Due to this change, config/s3.yml may raise Psych::BadAlias exception.
This bug can be resolved by using unsafe_load with Psych 4.0.

@yui-har yui-har requested a review from yoshiokaCB March 4, 2022 05:52
@yoshiokaCB
Copy link
Collaborator

Thank you for PR.

@yoshiokaCB yoshiokaCB merged commit 9bd37ec into redmica:master Mar 7, 2022
@yui-har yui-har deleted the issue-47946 branch March 7, 2022 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants