Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed - xcaim method should verify minIdleTime not idleTime #6191

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

jinia91
Copy link
Contributor

@jinia91 jinia91 commented Sep 24, 2024

The xClaim command interface in Spring Data Redis takes minIdleTime as an option. However, in the current implementation of xClaim in Redisson, it validates idleTime instead of minIdleTime, which causes a NullPointerException (NPE).

This PR fixes the validation to properly handle minIdleTime.

issue: #6192

@jinia91 jinia91 force-pushed the fix-xcaim-validation branch from 239caa4 to 6a9753d Compare September 24, 2024 11:38
@mrniko mrniko added this to the 3.37.0 milestone Sep 24, 2024
@mrniko mrniko added the bug label Sep 24, 2024
@jinia91 jinia91 force-pushed the fix-xcaim-validation branch from 6a9753d to bd8fba5 Compare September 24, 2024 15:14
@mrniko mrniko merged commit 1b2d715 into redisson:master Sep 25, 2024
4 checks passed
@mrniko
Copy link
Member

mrniko commented Sep 25, 2024

Thanks for contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants