Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pyupgrade for 3.8 #3236

Merged
merged 3 commits into from
May 23, 2024
Merged

Run pyupgrade for 3.8 #3236

merged 3 commits into from
May 23, 2024

Conversation

daveisfera
Copy link
Contributor

Pull Request check-list

  • Do tests and lints pass with this change? No new failures on my local
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)? I don't know how to do this
  • Is the new or changed code fully tested? No new code and changes should be safe/not change functionality
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)? N/A
  • Is there an example added to the examples folder (if applicable)? N/A
  • Was the change added to CHANGES file? Not needed since 3.8 is currently the minimum version

Description of change

Run pyupgrade with -py38-plus to remove anything from old versions

@gerzse gerzse added the maintenance Maintenance (CI, Releases, etc) label May 20, 2024
@gerzse
Copy link
Contributor

gerzse commented May 20, 2024

@daveisfera Thanks for this contribution!

The linters in the CI compain now:

redis/__init__.py:1:1: F401 'sys' imported but unused
redis/__init__.py:38:1: I004 isort found an unexpected blank line in imports
redis/__init__.py:39:1: I001 isort found an import in the wrong position
redis/utils.py:2:1: F401 'sys' imported but unused

It seems that pyupgrade does not remove unused imports. Could you, please take care of this, so we can merge the PR? Thanks!

@daveisfera
Copy link
Contributor Author

It seems that pyupgrade does not remove unused imports. Could you, please take care of this, so we can merge the PR? Thanks!

Done

@gerzse
Copy link
Contributor

gerzse commented May 21, 2024

@daveisfera Sorry, one more linter error showed up, in one of the test files. Some indentation in the set literals, it seems. You can try invoke linters locally, to make sure everything passes.

@daveisfera
Copy link
Contributor Author

I don't think my PR was the cause of that and it was a version change or something else or something, but I fixed it anyways

@gerzse
Copy link
Contributor

gerzse commented May 23, 2024

Thanks @daveisfera !

@gerzse gerzse merged commit 9908a4d into redis:master May 23, 2024
47 checks passed
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
Run pyupgrade for 3.8.
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
Run pyupgrade for 3.8.
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
Run pyupgrade for 3.8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants