Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a copy of the response from cache #3106

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Jan 10, 2024

Without this change a program can get a cache result, modify it and therefore modify the cache.

@dvora-h dvora-h added the bug Bug label Jan 10, 2024
@dvora-h dvora-h requested a review from a team January 10, 2024 12:26
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4a66c1e) 92.05% compared to head (51e44ea) 92.04%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3106      +/-   ##
==========================================
- Coverage   92.05%   92.04%   -0.01%     
==========================================
  Files         128      128              
  Lines       33195    33216      +21     
==========================================
+ Hits        30556    30573      +17     
- Misses       2639     2643       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chayim chayim changed the title Return a copy of the respnse from cache Return a copy of the response from cache Jan 11, 2024
@dvora-h dvora-h merged commit df29566 into redis:master Jan 11, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants