-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for WITHSCORE in zrank #2698
Conversation
@SoulPancake I updated your code to fix the linter issue. Maybe take a stab at it from here? |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #2698 +/- ##
==========================================
- Coverage 92.30% 92.26% -0.04%
==========================================
Files 116 116
Lines 30214 30229 +15
==========================================
+ Hits 27888 27891 +3
- Misses 2326 2338 +12
☔ View full report in Codecov by Sentry. |
@chayim Can you take a look at this |
LGTM @SoulPancake . Thank you for revisiting! |
The PR title was misleading. I've updated it. |
Closing as this is already merged in #2758. |
closes #2758
closes #2689