Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove weight parameter from TDIGEST.ADD and fix tests #2408

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Oct 6, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@dvora-h dvora-h requested a review from chayim October 6, 2022 08:30
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2022

Codecov Report

Base: 92.22% // Head: 92.19% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (b01613f) compared to base (b0883b7).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2408      +/-   ##
==========================================
- Coverage   92.22%   92.19%   -0.04%     
==========================================
  Files         110      110              
  Lines       28898    28894       -4     
==========================================
- Hits        26652    26638      -14     
- Misses       2246     2256      +10     
Impacted Files Coverage Δ
redis/commands/bf/info.py 100.00% <ø> (ø)
redis/commands/bf/commands.py 98.48% <100.00%> (-0.02%) ⬇️
tests/test_asyncio/test_bloom.py 99.64% <100.00%> (ø)
tests/test_bloom.py 99.67% <100.00%> (ø)
redis/commands/bf/__init__.py 96.73% <0.00%> (-3.27%) ⬇️
tests/test_cluster.py 96.85% <0.00%> (-0.24%) ⬇️
tests/test_asyncio/test_pubsub.py 99.37% <0.00%> (-0.16%) ⬇️
tests/test_asyncio/test_cluster.py 97.28% <0.00%> (-0.14%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chayim
Copy link
Contributor

chayim commented Oct 6, 2022

@dvora-h This works. I think we can finally remove the experimental flag, from this merge.

@dvora-h
Copy link
Collaborator Author

dvora-h commented Oct 6, 2022

@chayim Wouldn't you rather remove the flag after RedisBloom 2.4 release?

@dvora-h dvora-h merged commit 936d49f into redis:master Oct 6, 2022
@dvora-h dvora-h deleted the delete-add-weights branch October 6, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants