Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always clear reference to closed reader/writer #2077

Merged
merged 2 commits into from
Apr 4, 2022

Conversation

beasteers
Copy link
Contributor

@beasteers beasteers commented Mar 31, 2022

Description of change

Fixes #2065 - makes sure we always discard closed/closing writers

Pull Request check-list

  • Does $ tox pass with this change (including linting)? (tox doesn't pass on master and this doesn't attempt to fix any of those issues)
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2022

Codecov Report

Merging #2077 (deb281b) into master (ef4caf5) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2077      +/-   ##
==========================================
+ Coverage   91.20%   91.23%   +0.03%     
==========================================
  Files         100      100              
  Lines       21319    21361      +42     
==========================================
+ Hits        19443    19489      +46     
+ Misses       1876     1872       -4     
Impacted Files Coverage Δ
redis/asyncio/connection.py 82.75% <100.00%> (+0.11%) ⬆️
tests/test_search.py 99.17% <0.00%> (+0.02%) ⬆️
redis/commands/cluster.py 93.57% <0.00%> (+0.09%) ⬆️
tests/test_cluster.py 97.54% <0.00%> (+0.12%) ⬆️
redis/asyncio/client.py 90.63% <0.00%> (+0.17%) ⬆️
redis/commands/search/query.py 93.33% <0.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef4caf5...deb281b. Read the comment docs.

Copy link
Collaborator

@dvora-h dvora-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@beasteers Awesome, thank you for reporting this bug and contribute its fix!

@dvora-h dvora-h added the bug Bug label Apr 4, 2022
@dvora-h dvora-h merged commit ff93817 into redis:master Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

redis.asyncio trying to reuse a closed connection writer
3 participants