Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved RedisCluster's reinitialize_steps and documentation #1765

Merged
merged 8 commits into from
Dec 2, 2021

Conversation

barshaul
Copy link
Contributor

@barshaul barshaul commented Dec 2, 2021

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

  1. RedisCluster's reinitialize_steps have been refactored to moved_reinitialize_steps and the documentation has been improved
  2. Destructor added to ClusterNode to close connection pool when deleted
  3. Added a check to make sure the startup nodes have cluster mode enabled

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2021

Codecov Report

Merging #1765 (bf1d282) into master (d4a9825) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1765      +/-   ##
==========================================
+ Coverage   92.00%   92.05%   +0.04%     
==========================================
  Files          74       74              
  Lines       15617    15633      +16     
==========================================
+ Hits        14369    14391      +22     
+ Misses       1248     1242       -6     
Impacted Files Coverage Δ
tests/test_connection_pool.py 94.54% <ø> (ø)
redis/cluster.py 90.35% <100.00%> (+0.56%) ⬆️
tests/test_cluster.py 97.39% <100.00%> (+0.01%) ⬆️
tests/conftest.py 92.85% <0.00%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4a9825...bf1d282. Read the comment docs.

@barshaul barshaul marked this pull request as ready for review December 2, 2021 09:06
redis/cluster.py Outdated Show resolved Hide resolved
redis/cluster.py Outdated Show resolved Hide resolved
Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See changes

@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Dec 2, 2021
@chayim chayim changed the title Refactored RedisCluster's reinitialize_steps and improved the documentation, added destructor to ClusterNode. Improved RedisCluster's reinitialize_steps and documentation Dec 2, 2021
@chayim chayim merged commit b7ffec0 into redis:master Dec 2, 2021
@chayim chayim deleted the cluster_class branch December 2, 2021 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants