Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing the module version in loaded_modules #1648

Merged
merged 2 commits into from
Oct 26, 2021

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Oct 26, 2021

This is useful for the case where one wants to instantiate a module, knowing the back end version. The reason: beahviours may differ based on redis module versions.

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

This is useful for the case where one wants to instantiate a module, knowing the back end version. The reason: beahviours may differ based on redis module versions.
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2021

Codecov Report

Merging #1648 (1684ab6) into master (2b0a1e7) will decrease coverage by 0.02%.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1648      +/-   ##
==========================================
- Coverage   89.01%   88.98%   -0.03%     
==========================================
  Files          52       52              
  Lines       10112    10118       +6     
==========================================
+ Hits         9001     9004       +3     
- Misses       1111     1114       +3     
Impacted Files Coverage Δ
redis/commands/redismodules.py 78.94% <66.66%> (-7.72%) ⬇️
redis/client.py 87.76% <100.00%> (ø)
redis/commands/json/__init__.py 100.00% <100.00%> (ø)
redis/commands/search/__init__.py 82.35% <100.00%> (+0.53%) ⬆️
tests/test_connection.py 79.41% <100.00%> (ø)
tests/test_search.py 98.15% <0.00%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b0a1e7...1684ab6. Read the comment docs.

@chayim chayim merged commit 396e732 into master Oct 26, 2021
@chayim chayim deleted the ck-adding-versions-to-redismodules branch October 26, 2021 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants