Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementing the LMOVE and BLMOVE commands #1504

Merged
merged 13 commits into from
Aug 15, 2021
Merged

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Jul 14, 2021

closes #1503
closes #1447

Note - this passes in completion again - once my pr to fix unit tests is merged in. Checkboxes here are checked based on that assumption.

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Added support for the redis lmove and blmove command, new in 6.2. See #1434

@chayim chayim changed the title implementing the lmove command implementing the lmove and blmove commands Jul 14, 2021
@chayim chayim changed the title implementing the lmove and blmove commands implementing the LMOVE and BLMOVE commands Jul 14, 2021
@chayim chayim requested a review from andymccurdy July 15, 2021 07:16
redis/client.py Outdated Show resolved Hide resolved
@chayim chayim requested a review from abrookins July 25, 2021 09:19
redis/client.py Outdated Show resolved Hide resolved
@chayim
Copy link
Contributor Author

chayim commented Jul 30, 2021

@abrookins The recent doc update for blmove now shows that a timeout was required. Updates to blmove and tests to reflect that are now in this PR.

@chayim chayim merged commit 37e7c09 into redis:master Aug 15, 2021
@chayim chayim deleted the ck-lmove branch August 15, 2021 10:44
Andrew-Chen-Wang added a commit to aio-libs-abandoned/aioredis-py that referenced this pull request Oct 8, 2021
implementing the LMOVE and BLMOVE commands (redis/redis-py#1504)

Signed-off-by: Andrew-Chen-Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

redis lmove BRPOPLPUSH deprecated from Redis 6.2.0.
2 participants