Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify ssl_cert_reqs=None for TSL #1462

Closed
wants to merge 1 commit into from
Closed

Conversation

theod07
Copy link

@theod07 theod07 commented Mar 25, 2021

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Does travis tests pass with this change (enable it first in your forked repo and wait for the travis build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

This change updates connection.parse_url to set ssl_cert_reqs=None for rediss:// connections.

$ rq info -u rediss://:**********@ec2-34-206-168-30.compute-1.amazonaws.com:29259
Error 1 connecting to ec2-34-206-168-30.compute-1.amazonaws.com:29259. [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self signed certificate in certificate chain (_ssl.c:1091).

I came across this error after migrating to a redis environment with SSL/TSL. I found that it was caused by the connection. Heroku's documentation recommends instantiating the redis connection with ssl_cert_reqs=None.
https://devcenter.heroku.com/articles/heroku-redis#connecting-in-python

@illia-v
Copy link

illia-v commented Apr 19, 2021

ssl_cert_reqs is not supposed to be None by default. See #1016

@github-actions
Copy link
Contributor

This pull request is marked stale. It will be closed in 30 days if it is not updated.

@github-actions github-actions bot added the Stale label Apr 20, 2022
@github-actions github-actions bot closed this May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants