Skip testing resp3 parsing for async/py3.7

redis · Oct 17, 2023 · 78a5f92 · 78a5f92
1 parent 6f8b44a
commit 78a5f92
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/tests/test_asyncio/test_connect.py b/tests/test_asyncio/test_connect.py
@@ -2,6 +2,7 @@
 import logging
 import socket
 import ssl
+import sys
 from unittest.mock import patch
 
 import pytest
@@ -19,6 +20,7 @@
 
 
 _CLIENT_NAME = "test-suite-client"
+PY37 = sys.version_info[:2] == (3, 7)
 
 
 @pytest.fixture
@@ -77,14 +79,15 @@ async def test_tcp_ssl_connect(tcp_address):
         (6, 3, True, True),
     ],
 )
-# @pytest.mark.parametrize("use_protocol", [2, 3])
-# @pytest.mark.parametrize("use_auth", [False, True])
 async def test_tcp_auth(
     tcp_address, use_protocol, use_auth, use_server_ver, use_client_name
 ):
     """
     Test that various initial handshake cases are handled correctly by the client
     """
+    if use_protocol == 3 and PY37:
+        pytest.skip("Python 3.7 does not support protocol 3 for asyncio")
+
     got_auth = []
     got_protocol = None
     got_name = None

diff --git a/tests/test_connect.py b/tests/test_connect.py
@@ -75,8 +75,6 @@ def test_tcp_ssl_connect(tcp_address):
         (6, 3, True, True),
     ],
 )
-# @pytest.mark.parametrize("use_protocol", [2, 3])
-# @pytest.mark.parametrize("use_auth", [False, True])
 def test_tcp_auth(tcp_address, use_protocol, use_auth, use_server_ver, use_client_name):
     """
     Test that various initial handshake cases are handled correctly by the client