Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add slash in DEFAULT_ESCAPED_CHARS (#312) #376

Merged
merged 1 commit into from
Sep 11, 2022
Merged

fix: add slash in DEFAULT_ESCAPED_CHARS (#312) #376

merged 1 commit into from
Sep 11, 2022

Conversation

ninoseki
Copy link
Contributor

Add slash(/) in DEFAULT_ESCAPED_CHARS to fix #312.

@dvora-h
Copy link
Contributor

dvora-h commented Sep 11, 2022

@ninoseki Thanks for Thanks for fixing this bug!

@dvora-h dvora-h added the bug Something isn't working label Sep 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2022

Codecov Report

Merging #376 (02b6c53) into main (551429c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #376   +/-   ##
=======================================
  Coverage   78.53%   78.53%           
=======================================
  Files          14       14           
  Lines        1160     1160           
=======================================
  Hits          911      911           
  Misses        249      249           
Flag Coverage Δ
unit 78.53% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aredis_om/model/token_escaper.py 92.30% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dvora-h dvora-h merged commit 285f7c9 into redis:main Sep 11, 2022
@ninoseki ninoseki deleted the escape-slash branch September 12, 2022 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

find query cannot search for string that contains forward slash "/"
3 participants