Add delete_many to support for bulk deletes
#305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonprickett
previously approved these changes
Jul 18, 2022
chayim
reviewed
Jul 24, 2022
aredis_om/model/model.py
Outdated
| @@ -1115,9 +1115,13 @@ def key(self): | |||
| return self.make_primary_key(pk) | |||
|
|
|||
| @classmethod | |||
| async def delete(cls, pk: Any) -> int: | |||
| async def delete(cls, pk: Any, pipeline: Optional[Pipeline] = None) -> int: | |||
There was a problem hiding this comment.
I think delete_all and delete should call a new function named _delete underneath, that accepts a kwargs (at least). This would be a bit cleaner.
chayim
reviewed
Jul 24, 2022
chayim
reviewed
Jul 24, 2022
dvora-h
changed the title
delete_all to support for bulk deletesdelete_many to support for bulk deletes
|
@dvora-h don't know if you saw, but more-itertools/more-itertools#633 was merged and released to pypi. Bumping your dependency version should the first set of CI issues. |
chayim
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.