Ensure firstResponseLatency metric is a positive number (issue #740) #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's little excuse to skip testing. If there were proper tests in the first place, we'd had caught the bug earlier. I' going to add tests this time. |
mp911de
pushed a commit
that referenced
this pull request
Mar 24, 2018
Swapped calculation to subtract sent time from first response (response is usually later than sent). Original pull request: #741.
mp911de
pushed a commit
that referenced
this pull request
Mar 24, 2018
Swapped calculation to subtract sent time from first response (response is usually later than sent). Original pull request: #741.
mp911de
pushed a commit
that referenced
this pull request
Mar 24, 2018
Swapped calculation to subtract sent time from first response (response is usually later than sent). Original pull request: #741.
mp911de
pushed a commit
that referenced
this pull request
Mar 24, 2018
Swapped calculation to subtract sent time from first response (response is usually later than sent). Original pull request: #741.
|
That's merged and backported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is it all right if I skip testing it?
Rationale:
decode()orrecordLatency()