Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SLAVE_PREFERRED at valueOf method #671

Closed
wants to merge 1 commit into from
Closed

Support SLAVE_PREFERRED at valueOf method #671

wants to merge 1 commit into from

Conversation

be-hase
Copy link
Contributor

@be-hase be-hase commented Dec 18, 2017

It seems that we can not be created with valueOf only for SLAVE_PREFERRED.
so I added.

Make sure that:

  • You have read the contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

mp911de pushed a commit that referenced this pull request Dec 18, 2017
@be-hase @mp911de
Resolve ReadFrom.SLAVE_PREFERRED via ReadFrom.valueOf(…) #671
de953ef
mp911de added a commit that referenced this pull request Dec 18, 2017
@mp911de
Polishing #671
f81db76
mp911de pushed a commit that referenced this pull request Dec 18, 2017
@be-hase @mp911de
Resolve ReadFrom.SLAVE_PREFERRED via ReadFrom.valueOf(…) #671
5b846ee
mp911de added a commit that referenced this pull request Dec 18, 2017
@mp911de
Polishing #671
cc0ac33
mp911de pushed a commit that referenced this pull request Dec 18, 2017
@be-hase @mp911de
Resolve ReadFrom.SLAVE_PREFERRED via ReadFrom.valueOf(…) #671
5cd4297
mp911de added a commit that referenced this pull request Dec 18, 2017
@mp911de
Polishing #671
614877b
mp911de pushed a commit that referenced this pull request Dec 18, 2017
@be-hase @mp911de
Resolve ReadFrom.SLAVE_PREFERRED via ReadFrom.valueOf(…) #671
0c96fcd
mp911de added a commit that referenced this pull request Dec 18, 2017
@mp911de
Polishing #671
029db7b
@mp911de mp911de added the type: bug A general bug label Dec 18, 2017
@mp911de mp911de added this to the Lettuce 4.4.3 milestone Dec 18, 2017
@mp911de
Copy link
Collaborator

mp911de commented Dec 18, 2017

Thanks a lot. That's now merged and ported to the affected branches.

@mp911de mp911de closed this Dec 18, 2017
@be-hase be-hase deleted the feature/valueOfSlavePreferred branch December 18, 2017 16:29
@be-hase
Copy link
Contributor Author

be-hase commented Dec 18, 2017

thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
Lettuce 4.4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@be-hase @mp911de