DOC-4528 async hash examples #3069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tishun
reviewed
Dec 6, 2024
thachlp
pushed a commit
to thachlp/lettuce
that referenced
this pull request
Dec 31, 2024
* DOC-4528 first two examples * DOC-4528 added final example * DOC-4528 formatting changes * DOC-4528 removed unused imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that:
My first attempt at a Lettuce async code example for the hash datatype page. Although it passes the CI, I expect it's not ideal in terms of good practice. In particular:
del()call at the start from theCompletableFuture.allOf()call?CompletableFuture<Void> hmGet = setGetAll.thenCompose(...Is this the best way to handle this?Any other feedback about style, technique, and general Java knowledge would be very welcome :-)