Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not update Known nodes when refreshed topology is empty #3019

Closed
wants to merge 1 commit into from
Closed

Should not update Known nodes when refreshed topology is empty #3019

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/io/lettuce/core/masterreplica/SentinelConnector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,8 @@ private Runnable getTopologyRefreshRunnable(MasterReplicaTopologyRefresh refresh
EventRecorder.getInstance().record(new MasterReplicaTopologyChangedEvent(redisURI, nodes));

if (nodes.isEmpty()) {
LOG.warn("Topology refresh returned no nodes from {}", redisURI);
LOG.warn("Topology refresh returned no nodes from {}, skip refresh Known nodes", redisURI);
return;
}

LOG.debug("New topology: {}", nodes);
Expand Down