Add support for SPUBLISH #2757

[manish-manghwani]

implementation for #2757

Due to its similarity with PUBLISH and PUBSUB SHARDCHANNELS command, implementation is done in same way.
Test cases are not covered, can anyone give guidance on what all test cases should be covered for SPUBLISH Command.

Make sure that:

• You have read the contribution guidelines.
• You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
• You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
• You submit test cases (unit or integration tests) that back your changes.

[tishun]

Could you please also add the new command in the templates under src/main/templates/io/lettuce/core/api/BaseRedisCommands.java ?

This would allow us (if we decide to use the apigenerator in the /test tree) to generate the same signature.

Unfortunately we seem to be a bit shy on unit tests for the pub sub commands.
I would appreciate if you can add some, at least for the code you added.
Not mandatory considering we do not have any.

We would also want to add integration tests for this, especially if we want to verify the cluster specifics, in the following places:

• RedisClusterPubSubConnectionIntegrationTest
• PubSubCommantTest
• PubSubReactiveTest

However testing would be mostly impossible without the SSUBSCRIBE command implemented, as it would be hard to verify anything was published. I suggest leaving method stubs (with some or no implementation, but explaining what we need to test) with annotation @EnabledOnCommand("SSUBSCRIBE"), see #2776

[mp911de]

Care to rebase your pull request, given the conflicting changes?

[atakavci]

hey @manish-manghwani ,

i got backgrounds of this while i was working on #2813 .
do you mind if i take over this one ?

[manish-manghwani]

hey @manish-manghwani ,

i got backgrounds of this while i was working on #2813 . do you mind if i take over this one ?

hey @atakavci, sure please take over.

Do I need to close this PR?

[atakavci]

thanks, please do close this one.
you can follow #2757 if you want to see the changes