Support filtering commands on MicrometerCommandLatencyRecorder
#2407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mp911de
reviewed
May 15, 2023
| * @param commands list of Redis commands that are enabled for latency recording | ||
| * @return this {@link Builder}. | ||
| */ | ||
| public Builder enabledCommands(CommandType... commands) { |
There was a problem hiding this comment.
How about having a Predicate<RedisCommand> instead of protocol keywords? We could provide derived methods that can build a predicate to filter unwanted commands from being recorded?
There was a problem hiding this comment.
It seems nice to me, but I don't see how to implement it (without changes to other classes), since the CommandLatencyRecorder#recordCommandLatency does not include a RedisCommand as a parameter. Any sugestion on how to do it? At first glance, I would just add a Predicate<CommandType> to the MicrometerOptions, so we remove the responsability of filtering from the MicrometerCommandLatencyRecorder class.
mp911de
changed the title
MicrometerCommandLatencyRecorder
mp911de
pushed a commit
that referenced
this pull request
Aug 15, 2023
We can now filter particular commands from being recorded to Micrometer. Original pull request: #2407
|
Thank you for your contribution. That's merged and polished now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion about this proposal: #2406
Make sure that: