Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid PartitionSelectorException during refresh #2179

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Avoid PartitionSelectorException during refresh #2179

merged 1 commit into from
Oct 7, 2022

Conversation

tadashiya
Copy link
Contributor

To solve #2178, this PR moves invalidateCache() in the if clause below. Currently, we encounter PartitionSelectorException when cluster topology is refreshing.

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

@mp911de mp911de added the type: feature A new feature label Oct 7, 2022
@mp911de mp911de changed the title Avoid PartitionSelectorException when using enablePeriodicRefresh #2178 Avoid PartitionSelectorException during refresh Oct 7, 2022
@mp911de mp911de added this to the 6.2.1.RELEASE milestone Oct 7, 2022
@mp911de mp911de merged commit 0fc10d0 into redis:main Oct 7, 2022
mp911de pushed a commit that referenced this pull request Oct 7, 2022
@tadashiya @mp911de
Avoid PartitionSelectorException during refresh #2178
2715e51 
Original pull request: #2179.
Co-authored-by: Tadashi Yamasaki <[email protected]>
@mp911de
Copy link
Collaborator

mp911de commented Oct 7, 2022

Thank you for your contribution. That's merged and backported now.

@mp911de mp911de linked an issue Oct 7, 2022 that may be closed by this pull request
PartitionSelectorException during refresh of Partitions #2178
Closed
@tadashiya tadashiya deleted the move-invalidation branch October 7, 2022 09:54
@mp911de mp911de added type: regression A regression from a previous release and removed type: feature A new feature labels Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: regression A regression from a previous release
Projects
None yet
Milestone
6.2.1.RELEASE
Development

Successfully merging this pull request may close these issues.

PartitionSelectorException during refresh of Partitions
2 participants
@tadashiya @mp911de