Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit command latency events using JFR #1821

Closed
wants to merge 1 commit into from

Conversation

HashJang
Copy link
Contributor

@HashJang HashJang commented Aug 4, 2021

Fix: #1820

On the basis of current JFR Event generation, add JFR event for CommandLatencyEvent. And support summary report through JMC like the graph below:
image

@HashJang HashJang changed the title [#1820] add JFR Event for Command Latency fix #1820 add JFR Event for Command Latency Aug 4, 2021
Copy link
Collaborator

@sokomishalov sokomishalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mp911de
Copy link
Collaborator

mp911de commented Aug 18, 2021

I'm not sure that's something we want. Introducing JFR support for metrics events can impose a lot of load in default configurations. I think we need to document that in the reference docs and emphasize on how to disable JFR metrics events.

@HashJang
Copy link
Contributor Author

metrics

I'm not sure that's something we want. Introducing JFR support for metrics events can impose a lot of load in default configurations. I think we need to document that in the reference docs and emphasize on how to disable JFR metrics events.

JFR Event for Command Latency is only produced when Command Latency Event is created and Command Latency Event is created at scheduled rates. The amount would not be much enough to cause performance decrease.

And this JFR Event will only be created when:

  1. Command Latency Event is enabled;
  2. JFR Records is enabled
  3. the event is not disabled in JFR event configuration.

@mp911de mp911de changed the title fix #1820 add JFR Event for Command Latency Add support for JFR command latency events Sep 3, 2021
@mp911de mp911de changed the title Add support for JFR command latency events Emit command latency events using JFR Sep 3, 2021
@mp911de mp911de added this to the 6.2.0 milestone Sep 3, 2021
@mp911de mp911de added the type: feature A new feature label Sep 3, 2021
mp911de pushed a commit that referenced this pull request Sep 3, 2021
mp911de added a commit that referenced this pull request Sep 3, 2021
Reformat code, add copyright headers. Reduce class visibility.

Original pull request: #1821.
@mp911de mp911de closed this Sep 3, 2021
@mp911de
Copy link
Collaborator

mp911de commented Sep 3, 2021

Thank you for your contribution. That's merged and polished now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emit command latency events using JFR
3 participants