Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OBJECT FREQ #1686

Closed
wants to merge 1 commit into from
Closed

Conversation

dengliming
Copy link
Contributor

@dengliming dengliming commented Mar 22, 2021

Resolves #1684

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #1686 (7cb6011) into main (80b4018) will increase coverage by 0.03%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1686      +/-   ##
============================================
+ Coverage     78.31%   78.35%   +0.03%     
- Complexity     6723     6729       +6     
============================================
  Files           507      507              
  Lines         22649    22655       +6     
  Branches       2462     2462              
============================================
+ Hits          17738    17751      +13     
+ Misses         3764     3762       -2     
+ Partials       1147     1142       -5     
Impacted Files Coverage Δ Complexity Δ
...e/api/coroutines/RedisKeyCoroutinesCommandsImpl.kt 2.38% <0.00%> (-0.06%) 1.00 <0.00> (ø)
...va/io/lettuce/core/AbstractRedisAsyncCommands.java 96.46% <100.00%> (+<0.01%) 488.00 <1.00> (+1.00)
...io/lettuce/core/AbstractRedisReactiveCommands.java 89.92% <100.00%> (+0.01%) 477.00 <1.00> (+1.00)
...main/java/io/lettuce/core/RedisCommandBuilder.java 95.70% <100.00%> (+<0.01%) 534.00 <1.00> (+1.00)
.../java/io/lettuce/core/protocol/CommandKeyword.java 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
...e/core/masterreplica/SentinelTopologyProvider.java 81.08% <0.00%> (-2.71%) 9.00% <0.00%> (-1.00%)
...a/io/lettuce/core/protocol/ConnectionWatchdog.java 78.88% <0.00%> (-1.87%) 39.00% <0.00%> (-1.00%)
...core/cluster/ClusterDistributionChannelWriter.java 79.62% <0.00%> (-0.47%) 58.00% <0.00%> (-1.00%)
.../io/lettuce/core/dynamic/ReactiveTypeAdapters.java 86.95% <0.00%> (+0.43%) 1.00% <0.00%> (ø%)
...ce/core/masterreplica/SentinelTopologyRefresh.java 85.16% <0.00%> (+0.64%) 36.00% <0.00%> (ø%)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80b4018...7cb6011. Read the comment docs.

@mp911de mp911de added this to the 6.1.0 milestone Mar 26, 2021
@mp911de mp911de added the type: feature A new feature label Mar 26, 2021
@@ -210,6 +210,13 @@ void objectEncoding() {
assertThat(redis.objectEncoding(key)).isEqualTo("int");
}

@Test
void objectFreq() {
redis.configSet("maxmemory-policy", "allkeys-lfu");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line breaks OBJECT IDLETIME

@mp911de mp911de self-assigned this Mar 26, 2021
mp911de pushed a commit that referenced this pull request Mar 26, 2021
Original pull request: #1686.
mp911de added a commit that referenced this pull request Mar 26, 2021
Start sentence with uppercase letter. Fix test settings.

Original pull request: #1686.
@mp911de
Copy link
Collaborator

mp911de commented Mar 26, 2021

Thank you for your contribution. That's merged and polished now.

@mp911de mp911de closed this Mar 26, 2021
@dengliming dengliming deleted the object_freq branch March 26, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for OBJECT FREQ
2 participants