Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for MINID trimming strategy and the LIMIT argument to XADD and XTRIM #1649

Closed
wants to merge 1 commit into from
Closed

Add support for MINID trimming strategy and the LIMIT argument to XADD and XTRIM #1649

wants to merge 1 commit into from

Conversation

dengliming
Copy link
Contributor

@dengliming dengliming commented Mar 7, 2021 •
edited
Loading

Resolves #1582

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

@mp911de mp911de self-assigned this Mar 8, 2021
@mp911de
Copy link
Collaborator

mp911de commented Mar 8, 2021

This pull request looks pretty decent. Let me take it from here.

@mp911de mp911de added this to the 6.1 RC1 milestone Mar 8, 2021
@mp911de mp911de added the type: feature A new feature label Mar 8, 2021
mp911de pushed a commit that referenced this pull request Mar 8, 2021
@dengliming @mp911de
Add support for MINID trimming strategy and the LIMIT argument to XAD…
8117a12 
…D and XTRIM #1582

Original pull request: #1649.
mp911de added a commit that referenced this pull request Mar 8, 2021
@mp911de
Polishing #1582
0467858 
Introduce support for exact trimming. Tweak Javadoc. Rename minid to minId.

Original pull request: #1649.
@mp911de
Copy link
Collaborator

mp911de commented Mar 8, 2021

Thank you for your contribution. That's merged and polished now.

@mp911de mp911de closed this Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mp911de mp911de

Labels
type: feature A new feature
Projects
None yet
Milestone
6.1 RC1
Development

Successfully merging this pull request may close these issues.

Add support for MINID trimming strategy and the LIMIT argument to XADD and XTRIM
2 participants
@dengliming @mp911de