Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ScoredValueUnitTests #1648

Merged
merged 1 commit into from
Mar 8, 2021
Merged

Conversation

dengliming
Copy link
Contributor

fixes #1647

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

@codecov
Copy link

codecov bot commented Mar 6, 2021

Codecov Report

Merging #1648 (e4817b9) into main (81259cd) will decrease coverage by 0.02%.
The diff coverage is 82.14%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1648      +/-   ##
============================================
- Coverage     78.31%   78.28%   -0.03%     
- Complexity     6610     6612       +2     
============================================
  Files           490      490              
  Lines         22285    22301      +16     
  Branches       2433     2435       +2     
============================================
+ Hits          17452    17458       +6     
- Misses         3708     3717       +9     
- Partials       1125     1126       +1     
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/lettuce/core/KeyValue.java 70.58% <ø> (ø) 14.00 <0.00> (ø)
...java/io/lettuce/core/output/ScoredValueOutput.java 84.61% <ø> (ø) 4.00 <0.00> (ø)
.../io/lettuce/core/output/ScoredValueScanOutput.java 91.66% <50.00%> (-8.34%) 4.00 <1.00> (ø)
...ce/core/output/ScoredValueScanStreamingOutput.java 92.85% <50.00%> (-7.15%) 4.00 <1.00> (ø)
src/main/java/io/lettuce/core/Value.java 82.53% <71.42%> (-1.39%) 35.00 <3.00> (+3.00) ⬇️
src/main/java/io/lettuce/core/ScoredValue.java 67.50% <83.33%> (ø) 17.00 <0.00> (ø)
src/main/java/io/lettuce/core/GeoValue.java 56.81% <100.00%> (+2.76%) 15.00 <4.00> (+1.00)
.../io/lettuce/core/output/ScoredValueListOutput.java 100.00% <100.00%> (ø) 8.00 <1.00> (ø)
...ettuce/core/output/ScoredValueStreamingOutput.java 100.00% <100.00%> (ø) 4.00 <1.00> (ø)
.../lettuce/core/masterreplica/SentinelConnector.java 65.85% <0.00%> (-17.08%) 6.00% <0.00%> (-2.00%)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5698df7...e4817b9. Read the comment docs.

@mp911de mp911de added the type: regression A regression from a previous release label Mar 8, 2021
@mp911de mp911de added this to the 6.1 RC1 milestone Mar 8, 2021
@mp911de mp911de merged commit dc09af7 into redis:main Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: regression A regression from a previous release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ScoredValueUnitTests test fail
2 participants