Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MIGRATE AUTH2 option #1637

Closed
wants to merge 1 commit into from

Conversation

dengliming
Copy link
Contributor

@dengliming dengliming commented Mar 2, 2021

Resolves #1633

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #1637 (ae2de42) into main (76e3bec) will increase coverage by 0.01%.
The diff coverage is 7.69%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1637      +/-   ##
============================================
+ Coverage     78.42%   78.44%   +0.01%     
- Complexity     6519     6523       +4     
============================================
  Files           486      486              
  Lines         22035    22046      +11     
  Branches       2411     2413       +2     
============================================
+ Hits          17281    17294      +13     
+ Misses         3641     3640       -1     
+ Partials       1113     1112       -1     
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/lettuce/core/MigrateArgs.java 44.64% <0.00%> (-10.92%) 9.00 <0.00> (ø)
...ain/java/io/lettuce/core/protocol/CommandType.java 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
...ce/core/masterreplica/SentinelTopologyRefresh.java 85.62% <0.00%> (+0.65%) 35.00% <0.00%> (ø%)
.../io/lettuce/core/dynamic/ReactiveTypeAdapters.java 87.39% <0.00%> (+0.86%) 1.00% <0.00%> (ø%)
...a/io/lettuce/core/protocol/ConnectionWatchdog.java 79.73% <0.00%> (+1.96%) 39.00% <0.00%> (+1.00%)
.../lettuce/core/masterreplica/SentinelConnector.java 82.92% <0.00%> (+17.07%) 8.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76e3bec...ae2de42. Read the comment docs.

mp911de pushed a commit that referenced this pull request Mar 4, 2021
mp911de added a commit that referenced this pull request Mar 4, 2021
Tweak error message.

Original pull request: #1637.
@mp911de mp911de added the type: feature A new feature label Mar 4, 2021
@mp911de mp911de added this to the 6.1 RC1 milestone Mar 4, 2021
@mp911de
Copy link
Collaborator

mp911de commented Mar 4, 2021

Thank you for your contribution. That's merged and polished now.

@mp911de mp911de closed this Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for MIGRATE AUTH2 option
2 participants