Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ZDIFF and ZDIFFSTORE commands #1587

Closed
wants to merge 2 commits into from

Conversation

dengliming
Copy link
Contributor

@dengliming dengliming commented Jan 13, 2021

closes #1507

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #1587 (758f692) into main (9a5de3f) will increase coverage by 0.02%.
The diff coverage is 87.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1587      +/-   ##
============================================
+ Coverage     78.87%   78.90%   +0.02%     
- Complexity     6373     6380       +7     
============================================
  Files           479      479              
  Lines         21399    21422      +23     
  Branches       2341     2341              
============================================
+ Hits          16879    16902      +23     
+ Misses         3447     3446       -1     
- Partials       1073     1074       +1     
Impacted Files Coverage Δ Complexity Δ
...coroutines/RedisSortedSetCoroutinesCommandsImpl.kt 3.22% <0.00%> (-0.17%) 2.00 <0.00> (ø)
...va/io/lettuce/core/AbstractRedisAsyncCommands.java 96.05% <100.00%> (+0.02%) 439.00 <3.00> (+3.00)
...io/lettuce/core/AbstractRedisReactiveCommands.java 89.06% <100.00%> (+0.06%) 429.00 <3.00> (+3.00)
...main/java/io/lettuce/core/RedisCommandBuilder.java 95.11% <100.00%> (+0.04%) 482.00 <3.00> (+3.00)
...ain/java/io/lettuce/core/protocol/CommandType.java 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
.../io/lettuce/core/protocol/CommandExpiryWriter.java 73.07% <0.00%> (-3.85%) 15.00% <0.00%> (-2.00%)
...e/core/masterreplica/SentinelTopologyProvider.java 81.08% <0.00%> (-2.71%) 9.00% <0.00%> (-1.00%)
...a/io/lettuce/core/protocol/ConnectionWatchdog.java 77.77% <0.00%> (-1.31%) 38.00% <0.00%> (ø%)
...ce/core/masterreplica/SentinelTopologyRefresh.java 84.96% <0.00%> (-0.66%) 35.00% <0.00%> (ø%)
.../io/lettuce/core/dynamic/ReactiveTypeAdapters.java 87.82% <0.00%> (+0.43%) 1.00% <0.00%> (ø%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a5de3f...758f692. Read the comment docs.

Copy link
Collaborator

@sokomishalov sokomishalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should fix it in this or a separate PR

@mp911de mp911de self-assigned this Jan 14, 2021
@mp911de mp911de added the type: feature A new feature label Jan 14, 2021
@mp911de mp911de added this to the 6.1 M1 milestone Jan 14, 2021
mp911de pushed a commit that referenced this pull request Jan 14, 2021
@mp911de
Copy link
Collaborator

mp911de commented Jan 14, 2021

Thanks a lot, that's squashed and merged now.

@mp911de mp911de closed this Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for ZDIFF and ZDIFFSTORE commands
3 participants