Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ZRANGESTORE command #1581

Closed
wants to merge 1 commit into from

Conversation

dengliming
Copy link
Contributor

@dengliming dengliming commented Jan 12, 2021

closes #1506

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #1581 (d6c4660) into main (7c5e622) will increase coverage by 0.06%.
The diff coverage is 88.23%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1581      +/-   ##
============================================
+ Coverage     78.83%   78.90%   +0.06%     
- Complexity     6361     6390      +29     
============================================
  Files           479      479              
  Lines         21395    21431      +36     
  Branches       2345     2343       -2     
============================================
+ Hits          16867    16910      +43     
- Misses         3451     3453       +2     
+ Partials       1077     1068       -9     
Impacted Files Coverage Δ Complexity Δ
...coroutines/RedisSortedSetCoroutinesCommandsImpl.kt 3.17% <0.00%> (-0.22%) 2.00 <0.00> (ø)
...va/io/lettuce/core/AbstractRedisAsyncCommands.java 96.06% <100.00%> (+0.04%) 440.00 <4.00> (+6.00)
...io/lettuce/core/AbstractRedisReactiveCommands.java 89.08% <100.00%> (+0.13%) 430.00 <4.00> (+6.00)
...main/java/io/lettuce/core/RedisCommandBuilder.java 95.25% <100.00%> (+0.19%) 485.00 <5.00> (+8.00)
.../java/io/lettuce/core/protocol/CommandKeyword.java 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
...ain/java/io/lettuce/core/protocol/CommandType.java 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
...n/java/io/lettuce/core/cluster/ClusterCommand.java 70.73% <0.00%> (-17.08%) 18.00% <0.00%> (-1.00%)
...a/io/lettuce/core/protocol/ConnectionWatchdog.java 77.77% <0.00%> (-1.97%) 38.00% <0.00%> (-1.00%)
src/main/java/io/lettuce/core/RedisPublisher.java 78.94% <0.00%> (-0.35%) 5.00% <0.00%> (ø%)
.../api/coroutines/RedisListCoroutinesCommandsImpl.kt 3.84% <0.00%> (-0.33%) 1.00% <0.00%> (ø%)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c5e622...d6c4660. Read the comment docs.

@mp911de mp911de added the type: feature A new feature label Jan 13, 2021
@mp911de mp911de added this to the 6.1 M1 milestone Jan 13, 2021
Copy link
Collaborator

@mp911de mp911de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, great work. I'll merge this PR in the next days.

Copy link
Collaborator

@sokomishalov sokomishalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mp911de mp911de self-assigned this Jan 14, 2021
@mp911de
Copy link
Collaborator

mp911de commented Jan 14, 2021

Thanks a lot, that's merged and polished now.

@mp911de mp911de closed this Jan 14, 2021
mp911de pushed a commit that referenced this pull request Jan 14, 2021
mp911de added a commit that referenced this pull request Jan 14, 2021
Fix Javadoc parameter references, use AtCode syntax instead of HTML angled brackets <…>.

Original pull request: #1581.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for ZRANGESTORE command
3 participants