Add support for copy #1565
Add support for copy #1565
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1565 +/- ##
============================================
- Coverage 78.87% 78.62% -0.26%
- Complexity 6296 6340 +44
============================================
Files 470 476 +6
Lines 21044 21330 +286
Branches 2315 2333 +18
============================================
+ Hits 16599 16771 +172
- Misses 3380 3483 +103
- Partials 1065 1076 +11 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Thanks a lot. Our API is generated from the templates at src/main/templates. If we have the change there, we can run our API generator during the merge if you want us to take over that part.
Other than that, we should introduce a CopyArgs type to encapsulate copy arguments.
| } | ||
|
|
||
| @Override | ||
| public RedisFuture<Boolean> copy(K source, K destination, int destinationDd) { |
There was a problem hiding this comment.
It would make sense to introduce a CopyArgs object that includes destinationDb and replace options.
There was a problem hiding this comment.
I didn't notice COPY has replace argument :) CopyArgs added (builder, comments etc.)
| @@ -42,7 +42,7 @@ | |||
|
|
|||
| // Keys | |||
|
|
|||
| DEL, DUMP, EXISTS, EXPIRE, EXPIREAT, KEYS, MIGRATE, MOVE, OBJECT, PERSIST, PEXPIRE, PEXPIREAT, PTTL, RANDOMKEY, RENAME, RENAMENX, RESTORE, TOUCH, TTL, TYPE, SCAN, UNLINK, | |||
| DEL, DUMP, EXISTS, EXPIRE, EXPIREAT, KEYS, MIGRATE, MOVE, OBJECT, PERSIST, PEXPIRE, PEXPIREAT, PTTL, RANDOMKEY, RENAME, RENAMENX, RESTORE, TOUCH, TTL, TYPE, SCAN, UNLINK, COPY, | |||
There was a problem hiding this comment.
Nit: We typically order command types alphabetically
|
Thanks a lot for your comments :) I added also new signatures to |
|
Thank you for your contribution. That's merged and polished now. |
|
cool ! thank you for the review, going for the next one :) |
Hi,
this is initial implementation for #1508 ,
I created as much I as could inferring from the codebase and already implemented commands, but I need some hints what else have to be added :)