Added configurable timeout to connection string #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sergey-ushakov
commented
Nov 12, 2015
sergey-ushakov
commented
- RedisURI.java, RedisURITest.java - add timeout configuration to Redis connection string
…is connection string
| return; | ||
| } | ||
|
|
||
| String timeoutString = queryParam.substring(index + 1); |
There was a problem hiding this comment.
How about decoding the value part using URLDecoder.decode?
|
Thanks for the PR. I was tempted all the time to introduce options within the query string and you made the first step 👍 |
, RedisURITest.java - new test to check query string decoding, code formatting changes
|
Query string seems to be already decoded, added test for it. Also added lookup map. |
|
Great, thank you. I'll adopt your change for the 4.1 branch as well. |
mp911de
added a commit
that referenced
this pull request
Nov 12, 2015
Added configurable timeout to connection string
mp911de
pushed a commit
that referenced
this pull request
Nov 18, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.