Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support NOMKSTREAM option in xadd command #1504

Closed
wants to merge 1 commit into from
Closed

Support NOMKSTREAM option in xadd command #1504

wants to merge 1 commit into from

Conversation

dengliming
Copy link
Contributor

@dengliming dengliming commented Nov 8, 2020 •
edited
Loading

closes #1502

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

@codecov
Copy link

codecov bot commented Nov 8, 2020 •
edited
Loading

Codecov Report

Merging #1504 (0e0d9c1) into main (4395040) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1504      +/-   ##
============================================
+ Coverage     78.77%   78.81%   +0.03%     
- Complexity     6255     6262       +7     
============================================
  Files           464      464              
  Lines         20888    20893       +5     
  Branches       2300     2300              
============================================
+ Hits          16454    16466      +12     
+ Misses         3371     3367       -4     
+ Partials       1063     1060       -3
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/lettuce/core/XAddArgs.java 72.00% <100.00%> (+7.00%) 9.00 <2.00> (+3.00)
.../java/io/lettuce/core/protocol/CommandKeyword.java 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
...e/core/masterreplica/SentinelTopologyProvider.java 81.08% <0.00%> (-2.71%) 9.00% <0.00%> (-1.00%)
...ce/core/masterreplica/SentinelTopologyRefresh.java 84.96% <0.00%> (-0.66%) 35.00% <0.00%> (ø%)
.../io/lettuce/core/dynamic/ReactiveTypeAdapters.java 88.26% <0.00%> (+0.86%) 1.00% <0.00%> (ø%)
.../java/io/lettuce/core/protocol/CommandHandler.java 75.38% <0.00%> (+1.79%) 113.00% <0.00%> (+4.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4395040...0e0d9c1. Read the comment docs.

@mp911de mp911de added the type: feature A new feature label Nov 8, 2020
@mp911de mp911de added this to the 6.1 M1 milestone Nov 8, 2020
mp911de pushed a commit that referenced this pull request Nov 8, 2020
@dengliming @mp911de
Support NOMKSTREAM option in xadd command #1502
1a1e0be 
Original pull request: #1504.
mp911de added a commit that referenced this pull request Nov 8, 2020
@mp911de
Polishing #1502
7410f5d 
Consistently use lowercase for nomkstream to align with XGroupCreateArgs.

Introduce nomkstream() factory method. Tweak Javadoc, simplify tests.

Original pull request: #1504.
@mp911de
Copy link
Collaborator

mp911de commented Nov 8, 2020

Thank you for your contribution. That's merged and polished now.

@mp911de mp911de closed this Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: feature A new feature
Projects
None yet
Milestone
6.1 M1
Development

Successfully merging this pull request may close these issues.

Support NOMKSTREAM option in xadd command
2 participants
@dengliming @mp911de