Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GET parameter to SET command #1461

Closed
wants to merge 3 commits into from
Closed

Conversation

anshlykov
Copy link
Contributor

Closes #1442.

@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #1461 (cb4972f) into main (137aa14) will decrease coverage by 0.18%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1461      +/-   ##
============================================
- Coverage     78.89%   78.70%   -0.19%     
- Complexity     6295     6347      +52     
============================================
  Files           470      476       +6     
  Lines         21028    21330     +302     
  Branches       2315     2333      +18     
============================================
+ Hits          16590    16788     +198     
- Misses         3375     3472      +97     
- Partials       1063     1070       +7     
Impacted Files Coverage Δ Complexity Δ
...pi/coroutines/RedisStringCoroutinesCommandsImpl.kt 8.57% <0.00%> (-0.52%) 3.00 <0.00> (ø)
...va/io/lettuce/core/AbstractRedisAsyncCommands.java 95.80% <50.00%> (-0.19%) 433.00 <1.00> (+2.00) ⬇️
...io/lettuce/core/AbstractRedisReactiveCommands.java 88.75% <50.00%> (-0.14%) 423.00 <1.00> (+2.00) ⬇️
...main/java/io/lettuce/core/RedisCommandBuilder.java 95.05% <100.00%> (+0.03%) 477.00 <2.00> (+3.00)
...c/main/java/io/lettuce/core/ConnectionBuilder.java 66.40% <0.00%> (-20.62%) 31.00% <0.00%> (+4.00%) ⬇️
src/main/java/io/lettuce/core/KillArgs.java 75.00% <0.00%> (-15.00%) 11.00% <0.00%> (ø%)
...ce/core/resource/MappingSocketAddressResolver.java 59.09% <0.00%> (-9.34%) 5.00% <0.00%> (ø%)
...o/lettuce/core/resource/SocketAddressResolver.java 68.18% <0.00%> (-6.82%) 7.00% <0.00%> (ø%)
...main/java/io/lettuce/core/AbstractRedisClient.java 77.96% <0.00%> (-5.63%) 45.00% <0.00%> (-7.00%)
.../java/io/lettuce/core/resource/KqueueProvider.java 16.98% <0.00%> (-5.47%) 2.00% <0.00%> (ø%)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 137aa14...cb4972f. Read the comment docs.

@mp911de
Copy link
Collaborator

mp911de commented Oct 15, 2020

This approach works only if the value is a String. Other typed values (e.g. binary content) would be decoded as String which breaks functionality. I think we need to introduce a new setAndGet method with the return type V

@dengliming
Copy link
Contributor

@anshlykov Hey~ are you still working on this?

@mp911de
Copy link
Collaborator

mp911de commented Nov 7, 2020

Going forward, let's call this method V setGet (we have something similar with clientGetname and debugObject)

@anshlykov
Copy link
Contributor Author

Sorry for the delay. I forgot to update this PR. I will make changes as per the comment above and push today or tomorrow

@mp911de mp911de self-assigned this Jan 14, 2021
@mp911de mp911de added the type: feature A new feature label Jan 14, 2021
@mp911de mp911de added this to the 6.1 M1 milestone Jan 14, 2021
mp911de pushed a commit that referenced this pull request Jan 14, 2021
mp911de added a commit that referenced this pull request Jan 14, 2021
Tweak Javadoc, add author tags.

Original pull request: #1461
@mp911de
Copy link
Collaborator

mp911de commented Jan 14, 2021

Thank you for your contribution. That's merged and polished now.

@mp911de mp911de closed this Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for SET … GET option
4 participants