-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ZADD GT/LT options #1455
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1455 +/- ##
============================================
- Coverage 78.92% 78.84% -0.09%
Complexity 6187 6187
============================================
Files 460 460
Lines 20800 20814 +14
Branches 2302 2304 +2
============================================
- Hits 16417 16411 -6
- Misses 3324 3342 +18
- Partials 1059 1061 +2 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, great work. Can you add also @since
tags (version 6.1) to all newly introduced public
methods in ZAddArgs
and yourself as @author
?
I think we also need a guard to the @Test
methods when running the tests against an older Redis version, but I currently don't have a good idea. Maybe it's time to introduce @EnabledOnRedisVersion
. Happy for suggestions.
@mp911de Great idea. Maybe we should track this with separated issue? Seems that we can get the current redis version by calling |
For now, we can guard the tests with |
Thanks. will update it later. |
No worries, I'm about to merge and polish up this PR. |
Original pull request: #1455.
Thank you for your contribution. That's merged and polished now. |
Make sure that:
closes #1451