Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EXEC without MULTI when using coroutines over async #1441

Conversation

sokomishalov
Copy link
Collaborator

No description provided.

@sokomishalov sokomishalov reopened this Oct 5, 2020
@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #1441 into main will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1441      +/-   ##
============================================
+ Coverage     78.80%   78.83%   +0.02%     
- Complexity     6181     6185       +4     
============================================
  Files           460      460              
  Lines         20800    20800              
  Branches       2302     2302              
============================================
+ Hits          16392    16398       +6     
+ Misses         3341     3339       -2     
+ Partials       1067     1063       -4     
Impacted Files Coverage Δ Complexity Δ
...uce/core/api/async/RedisAsyncCommandsExtensions.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...a/io/lettuce/core/protocol/ConnectionWatchdog.java 77.77% <0.00%> (-1.97%) 38.00% <0.00%> (-1.00%)
.../io/lettuce/core/dynamic/ReactiveTypeAdapters.java 87.82% <0.00%> (-0.44%) 1.00% <0.00%> (ø%)
.../java/io/lettuce/core/protocol/CommandHandler.java 75.38% <0.00%> (+1.79%) 113.00% <0.00%> (+4.00%)
.../io/lettuce/core/protocol/ReconnectionHandler.java 83.78% <0.00%> (+4.05%) 23.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f75b85...32cadc2. Read the comment docs.

@mp911de
Copy link
Collaborator

mp911de commented Oct 26, 2020

Care to extend the commit message what's fixed or what the problem was?

@mp911de mp911de added the type: bug A general bug label Oct 26, 2020
@sokomishalov sokomishalov force-pushed the fix/async-transaction-closure-fix branch from e489cb0 to 32cadc2 Compare October 26, 2020 12:12
@sokomishalov
Copy link
Collaborator Author

sokomishalov commented Oct 26, 2020

My bad.
"io.lettuce.core.RedisCommandExecutionException: ERR EXEC without MULTI" occurred because of discarding transaction onFailure block and then trying to execute it.
Reproduction is provided with a new test.

@mp911de mp911de changed the title Kotlin async transaction closure fix Fix EXEC without MULTI when using coroutines over async Oct 26, 2020
@mp911de mp911de added this to the 6.0.1 milestone Oct 26, 2020
mp911de added a commit that referenced this pull request Oct 26, 2020
Flush keys before running tests.
mp911de added a commit that referenced this pull request Oct 26, 2020
Flush keys before running tests.
@mp911de
Copy link
Collaborator

mp911de commented Oct 26, 2020

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de closed this Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants