Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently use Javadoc wording in BoundedPoolConfig.Builder #1337

Closed
wants to merge 1 commit into from
Closed

Consistently use Javadoc wording in BoundedPoolConfig.Builder #1337

wants to merge 1 commit into from

Conversation

maestroua
Copy link

@maestroua maestroua commented Jul 8, 2020

// It's kind of bad that javadoc is duplicated for this fields both in BoundedAsyncPool and BoundedPoolConfig.

@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #1337 into main will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1337      +/-   ##
============================================
+ Coverage     80.21%   80.32%   +0.11%     
- Complexity     6143     6159      +16     
============================================
  Files           439      439              
  Lines         20260    20260              
  Branches       2276     2276              
============================================
+ Hits          16251    16274      +23     
+ Misses         2956     2933      -23     
  Partials       1053     1053              
Impacted Files Coverage Δ Complexity Δ
...ava/io/lettuce/core/support/BoundedPoolConfig.java 100.00% <ø> (ø) 6.00 <0.00> (ø)
.../io/lettuce/core/protocol/ReconnectionHandler.java 79.72% <0.00%> (-4.06%) 22.00% <0.00%> (ø%)
...a/io/lettuce/core/pubsub/PubSubCommandHandler.java 87.03% <0.00%> (-2.78%) 39.00% <0.00%> (-2.00%)
...e/core/masterreplica/SentinelTopologyProvider.java 81.08% <0.00%> (-2.71%) 9.00% <0.00%> (-1.00%)
.../io/lettuce/core/dynamic/ReactiveTypeAdapters.java 86.95% <0.00%> (-1.31%) 1.00% <0.00%> (ø%)
...ce/core/masterreplica/SentinelTopologyRefresh.java 84.96% <0.00%> (-0.66%) 35.00% <0.00%> (ø%)
...main/java/io/lettuce/core/RedisCommandBuilder.java 94.71% <0.00%> (+0.32%) 460.00% <0.00%> (+2.00%)
...io/lettuce/core/AbstractRedisReactiveCommands.java 89.46% <0.00%> (+0.41%) 413.00% <0.00%> (+2.00%)
...va/io/lettuce/core/AbstractRedisAsyncCommands.java 96.53% <0.00%> (+0.43%) 422.00% <0.00%> (+2.00%)
.../java/io/lettuce/core/protocol/CommandHandler.java 75.19% <0.00%> (+1.79%) 114.00% <0.00%> (+5.00%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7272fb6...9ce0f19. Read the comment docs.

@mp911de mp911de added the type: documentation A documentation update label Jul 9, 2020
mp911de added a commit that referenced this pull request Jul 9, 2020
Reformat code. Add javadoc method links.
mp911de added a commit that referenced this pull request Jul 9, 2020
Reformat code. Add javadoc method links.
@mp911de mp911de changed the title fix javadoc BoundedPoolConfig.Builder Consistently use Javadoc wording in BoundedPoolConfig.Builder Jul 9, 2020
@mp911de
Copy link
Collaborator

mp911de commented Jul 9, 2020

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de closed this Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants