Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce method(decode)'s bytecode size #1324

Closed
wants to merge 1 commit into from
Closed

Conversation

hellyguo
Copy link
Contributor

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

link to issue #1323
reuse StateMachineUnitTests as my test.

@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #1324 into 5.3.x will decrease coverage by 0.01%.
The diff coverage is 96.77%.

Impacted file tree graph

@@             Coverage Diff              @@
##              5.3.x    #1324      +/-   ##
============================================
- Coverage     79.77%   79.76%   -0.02%     
- Complexity     5878     5879       +1     
============================================
  Files           423      423              
  Lines         19632    19650      +18     
  Branches       2236     2230       -6     
============================================
+ Hits          15662    15674      +12     
- Misses         2939     2946       +7     
+ Partials       1031     1030       -1     
Impacted Files Coverage Δ Complexity Δ
...va/io/lettuce/core/protocol/RedisStateMachine.java 90.57% <96.77%> (+2.13%) 56.00 <16.00> (+4.00)
...io/lettuce/core/masterslave/SentinelConnector.java 65.00% <0.00%> (-17.50%) 6.00% <0.00%> (-2.00%)
...uce/core/masterslave/SentinelTopologyProvider.java 81.08% <0.00%> (-2.71%) 9.00% <0.00%> (-1.00%)
...tuce/core/masterslave/SentinelTopologyRefresh.java 84.96% <0.00%> (-0.66%) 35.00% <0.00%> (ø%)
...java/io/lettuce/core/protocol/DefaultEndpoint.java 70.60% <0.00%> (-0.49%) 95.00% <0.00%> (ø%)
...lettuce/core/internal/AsyncConnectionProvider.java 84.70% <0.00%> (+1.17%) 17.00% <0.00%> (+1.00%)
...e/core/cluster/NodeSelectionInvocationHandler.java 78.57% <0.00%> (+1.42%) 38.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ddc0c9...173c65e. Read the comment docs.

@mp911de mp911de linked an issue Jun 29, 2020 that may be closed by this pull request
mp911de added a commit that referenced this pull request Jul 1, 2020
Reformat code. Rename interfaces and methods to follow handle…() naming scheme.
@mp911de
Copy link
Collaborator

mp911de commented Jul 1, 2020

Thank you for your contribution. That's merged and polished via 6f89976 now. Do you want to submit another pull request for the main branch as the code in RedisStateMachine changed quite a bit across versions?

@mp911de mp911de closed this Jul 1, 2020
@mp911de mp911de added the type: feature A new feature label Jul 1, 2020
@mp911de mp911de added this to the 5.3.2 milestone Jul 1, 2020
@hellyguo
Copy link
Contributor Author

hellyguo commented Jul 1, 2020

I will have a try. Thanks @mp911de .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce RedisStateMachine bytecode size
2 participants