Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for client id command #1230

Closed
wants to merge 2 commits into from
Closed

Conversation

dengliming
Copy link
Contributor

@dengliming dengliming commented Feb 14, 2020

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

@codecov
Copy link

codecov bot commented Feb 14, 2020

Codecov Report

Merging #1230 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1230      +/-   ##
============================================
- Coverage     78.81%   78.78%   -0.04%     
+ Complexity     5804     5803       -1     
============================================
  Files           424      424              
  Lines         19492    19496       +4     
  Branches       2213     2213              
============================================
- Hits          15363    15360       -3     
- Misses         3096     3100       +4     
- Partials       1033     1036       +3
Impacted Files Coverage Δ Complexity Δ
...va/io/lettuce/core/AbstractRedisAsyncCommands.java 97.05% <100%> (ø) 408 <1> (+1) ⬆️
...io/lettuce/core/AbstractRedisReactiveCommands.java 89.12% <100%> (+0.02%) 396 <1> (+1) ⬆️
...main/java/io/lettuce/core/RedisCommandBuilder.java 94.27% <100%> (ø) 446 <1> (+1) ⬆️
...n/java/io/lettuce/core/cluster/ClusterCommand.java 73.17% <0%> (-4.88%) 19% <0%> (ø)
...lettuce/core/internal/AsyncConnectionProvider.java 85.18% <0%> (-2.47%) 16% <0%> (-1%)
...a/io/lettuce/core/protocol/ConnectionWatchdog.java 77.77% <0%> (-1.97%) 37% <0%> (-1%)
...e/core/metrics/DefaultCommandLatencyCollector.java 76.66% <0%> (-0.84%) 22% <0%> (ø)
...va/io/lettuce/core/protocol/RedisStateMachine.java 79.18% <0%> (-0.69%) 89% <0%> (-1%)
.../io/lettuce/core/dynamic/ReactiveTypeAdapters.java 85.13% <0%> (ø) 1% <0%> (ø) ⬇️
.../io/lettuce/core/protocol/ReconnectionHandler.java 83.78% <0%> (+4.05%) 21% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8ce24c...0e2649f. Read the comment docs.

@dengliming dengliming requested a review from mp911de February 15, 2020 19:05
@dengliming
Copy link
Contributor Author

@mp911de

@mp911de
Copy link
Collaborator

mp911de commented Feb 17, 2020

Thank you for your contribution. I've seen it on Friday already. No need to nag every day.

@mp911de mp911de linked an issue Feb 21, 2020 that may be closed by this pull request
mp911de pushed a commit that referenced this pull request Feb 21, 2020
mp911de added a commit that referenced this pull request Feb 21, 2020
Tweak documentation. Add since tags.

Original pull request: #1230.
mp911de pushed a commit that referenced this pull request Feb 21, 2020
mp911de added a commit that referenced this pull request Feb 21, 2020
Tweak documentation. Add since tags.

Original pull request: #1230.
@mp911de
Copy link
Collaborator

mp911de commented Feb 21, 2020

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de closed this Feb 21, 2020
@mp911de mp911de added this to the 5.3.0 milestone Feb 21, 2020
@mp911de mp911de added the type: feature A new feature label Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CLIENT ID command
2 participants