Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code for pub/sub to listen on the stateful connection object. #1207

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

judepereira
Copy link
Contributor

@judepereira judepereira commented Jan 14, 2020

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #1207 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1207      +/-   ##
============================================
+ Coverage     78.73%   78.79%   +0.05%     
  Complexity     5787     5787              
============================================
  Files           424      424              
  Lines         19449    19449              
  Branches       2205     2205              
============================================
+ Hits          15314    15324      +10     
+ Misses         3102     3098       -4     
+ Partials       1033     1027       -6
Impacted Files Coverage Δ Complexity Δ
.../java/io/lettuce/core/resource/PromiseAdapter.java 38.46% <0%> (-15.39%) 2% <0%> (-1%)
...ttuce/core/support/ClientResourcesFactoryBean.java 46.66% <0%> (-13.34%) 4% <0%> (-1%)
.../io/lettuce/core/protocol/ReconnectionHandler.java 79.72% <0%> (ø) 22% <0%> (ø) ⬇️
...va/io/lettuce/core/protocol/RedisStateMachine.java 79.86% <0%> (+0.68%) 90% <0%> (+1%) ⬆️
src/main/java/io/lettuce/core/RedisPublisher.java 80.17% <0%> (+0.88%) 5% <0%> (ø) ⬇️
...a/io/lettuce/core/pubsub/PubSubCommandHandler.java 88.46% <0%> (+1.28%) 27% <0%> (+1%) ⬆️
.../io/lettuce/core/dynamic/ReactiveTypeAdapters.java 85.81% <0%> (+1.35%) 1% <0%> (ø) ⬇️
src/main/java/io/lettuce/core/ScanStream.java 87.66% <0%> (+1.94%) 24% <0%> (ø) ⬇️
...a/io/lettuce/core/protocol/ConnectionWatchdog.java 79.73% <0%> (+1.96%) 37% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fed2f8...e6ffade. Read the comment docs.

@mp911de mp911de added the type: documentation A documentation update label Jan 15, 2020
@mp911de mp911de merged commit a22864e into redis:master Jan 15, 2020
@mp911de
Copy link
Collaborator

mp911de commented Jan 15, 2020

Thank you for your contribution. That's merged now.

@judepereira judepereira deleted the patch-1 branch January 15, 2020 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants