Disable RedisURIBuilderUnitTests failing on Windows OS #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add @DisabledOnOs(OS.WINDOWS) to two tests - `redisSocket` and `redisSocketWithPassword` that fail in Windows: ``` java.lang.IllegalArgumentException: Illegal character in authority at index 15: redis-socket://C:\Users\konstantinsh\IdeaProjects\lettuce-core\work\socket-6479 at java.base/java.net.URI.create(URI.java:883) at io.lettuce.core.RedisURI.create(RedisURI.java:233) ``` Tests are disabled on Windows as socket connections are not supposed to be used on OS other that Unix.
Codecov Report
@@ Coverage Diff @@
## master #1204 +/- ##
============================================
- Coverage 78.78% 78.76% -0.03%
+ Complexity 5786 5784 -2
============================================
Files 424 424
Lines 19443 19443
Branches 2204 2204
============================================
- Hits 15319 15315 -4
- Misses 3094 3097 +3
- Partials 1030 1031 +1
Continue to review full report at Codecov.
|
mp911de
changed the title
mp911de
pushed a commit
that referenced
this pull request
Jan 13, 2020
Add @DisabledOnOs(OS.WINDOWS) to two tests - `redisSocket` and `redisSocketWithPassword` that fail in Windows: ``` java.lang.IllegalArgumentException: Illegal character in authority at index 15: redis-socket://C:\Users\konstantinsh\IdeaProjects\lettuce-core\work\socket-6479 at java.base/java.net.URI.create(URI.java:883) at io.lettuce.core.RedisURI.create(RedisURI.java:233) ``` Tests are disabled on Windows as socket connections are not supposed to be used on OS other that Unix.
mp911de
pushed a commit
that referenced
this pull request
Jan 13, 2020
Add @DisabledOnOs(OS.WINDOWS) to two tests - `redisSocket` and `redisSocketWithPassword` that fail in Windows: ``` java.lang.IllegalArgumentException: Illegal character in authority at index 15: redis-socket://C:\Users\konstantinsh\IdeaProjects\lettuce-core\work\socket-6479 at java.base/java.net.URI.create(URI.java:883) at io.lettuce.core.RedisURI.create(RedisURI.java:233) ``` Tests are disabled on Windows as socket connections are not supposed to be used on OS other that Unix.
|
Thank you for your contribution. That's merged and backported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add @DisabledOnOs(OS.WINDOWS) to two tests -
redisSocketandredisSocketWithPasswordthat fail in Windows:Tests are disabled on Windows as socket connections are not supposed
to be used on OS other that Unix.