Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement codec adapter (fixes #1122) #1123

Closed
wants to merge 1 commit into from

Conversation

dmandalidis
Copy link
Contributor

  • Supports using different codecs for keys and values

Unit tests pending until final implementation

- Supports using different codecs for keys and values
@codecov
Copy link

codecov bot commented Sep 14, 2019

Codecov Report

Merging #1123 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1123      +/-   ##
============================================
+ Coverage     80.33%   80.35%   +0.01%     
- Complexity     5810     5816       +6     
============================================
  Files           416      417       +1     
  Lines         19126    19135       +9     
  Branches       2217     2217              
============================================
+ Hits          15364    15375      +11     
- Misses         2730     2731       +1     
+ Partials       1032     1029       -3
Impacted Files Coverage Δ Complexity Δ
.../java/io/lettuce/core/codec/RedisCodecAdapter.java 0% <0%> (ø) 0 <0> (?)
...io/lettuce/core/masterslave/SentinelConnector.java 65% <0%> (-17.5%) 6% <0%> (-2%)
.../io/lettuce/core/protocol/ReconnectionHandler.java 72.89% <0%> (-2.81%) 26% <0%> (ø)
...uce/core/masterslave/SentinelTopologyProvider.java 80.55% <0%> (-2.78%) 9% <0%> (-1%)
src/main/java/io/lettuce/core/Operators.java 34.54% <0%> (-1.82%) 10% <0%> (-1%)
...tuce/core/masterslave/SentinelTopologyRefresh.java 84.86% <0%> (-1.32%) 35% <0%> (ø)
...main/java/io/lettuce/core/AbstractRedisClient.java 76.81% <0%> (-0.49%) 47% <0%> (-1%)
.../io/lettuce/core/dynamic/ReactiveTypeAdapters.java 85.13% <0%> (ø) 1% <0%> (ø) ⬇️
src/main/java/io/lettuce/core/RedisPublisher.java 77.87% <0%> (+0.29%) 5% <0%> (ø) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 294b378...0b3d0fb. Read the comment docs.

@mp911de mp911de added the type: feature A new feature label Sep 17, 2019
@mp911de mp911de added this to the 5.2.0 milestone Sep 17, 2019
Copy link
Collaborator

@mp911de mp911de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. That looks just about right and I'm going to merge that PR later this week.

mp911de pushed a commit that referenced this pull request Sep 19, 2019
- Supports using different codecs for keys and values

Original pull request: #1123.
mp911de added a commit that referenced this pull request Sep 19, 2019
Rename wrapper type to ComposedRedisCodec. Introduce RedisCodec.of(…) factory method.

Add tests.

Original pull request: #1123.
@mp911de
Copy link
Collaborator

mp911de commented Sep 19, 2019

That's merged and polished now.

@mp911de mp911de closed this Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants